Skip to content

Conversation

@dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Aug 26, 2021

No description provided.

@dgp1130 dgp1130 added the action: merge The PR is ready for merge by the caretaker label Aug 26, 2021
@google-cla google-cla bot added the cla: yes label Aug 26, 2021
@dgp1130 dgp1130 requested a review from clydin August 26, 2021 18:20
@dgp1130 dgp1130 added the target: major This PR is targeted for the next major release label Aug 26, 2021
@alan-agius4
Copy link
Collaborator

Failure is related to the discussion on slack.

@dgp1130
Copy link
Collaborator Author

dgp1130 commented Aug 26, 2021

Link to relevant discussion

Seems to be mostly a testing issue. Can we/should we push through and release anyways? This is a prerelease at least. Or would it be better to skip this week as we figure out a proper fix for the issue?

@alan-agius4
Copy link
Collaborator

Link to relevant discussion

Seems to be mostly a testing issue. Can we/should we push through and release anyways? This is a prerelease at least. Or would it be better to skip this week as we figure out a proper fix for the issue?

I don’t think this warrant postponing the release.

@dgp1130
Copy link
Collaborator Author

dgp1130 commented Aug 26, 2021

Decision is to release since this seems to be just a build issue and it is a prerelease, so the risk and impact are relatively low.

@dgp1130 dgp1130 merged commit 4e90faa into angular:master Aug 26, 2021
@dgp1130 dgp1130 deleted the release-stage-13.0.0-next.2 branch August 26, 2021 19:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants