build: experimental stamping and snapshot repo substitutions#22491
Merged
alan-agius4 merged 3 commits intoangular:masterfrom Jan 21, 2022
aspect-build:experimental-stamp
Merged
build: experimental stamping and snapshot repo substitutions#22491alan-agius4 merged 3 commits intoangular:masterfrom aspect-build:experimental-stamp
alan-agius4 merged 3 commits intoangular:masterfrom
aspect-build:experimental-stamp
Conversation
kormide
commented
Jan 12, 2022
kormide
commented
Jan 12, 2022
| load("//:constants.bzl", "SNAPSHOT_REPOS") | ||
|
|
||
| # jq filter that replaces package.json dependencies with snapshot repos | ||
| SNAPSHOT_REPO_JQ_FILTER = _generate_snapshot_repo_filter() |
Contributor
Author
There was a problem hiding this comment.
If preferred, I could just hardcode this into a jq filter file. I thought it would be cleaner to generate it from SNAPSHOT_REPOS, but I'm on the fence.
kormide
commented
Jan 12, 2022
Comment on lines
+416
to
+420
| } else if ((obj[depName] as string).match(/\b0\.0\.0-EXPERIMENTAL-PLACEHOLDER\b/)) { | ||
| obj[depName] = (obj[depName] as string).replace( | ||
| /\b0\.0\.0-EXPERIMENTAL-PLACEHOLDER\b/, | ||
| v, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Not ideal to add this extra condition here but this build script will be deleted after flipping to the bazel build script.
josephperrott
added
area: build & ci
josephperrott
added
the
action: review
alan-agius4
reviewed
Jan 20, 2022
alan-agius4
approved these changes
Jan 20, 2022
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, just one small nit
devversion
approved these changes
Jan 20, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@josephperrott @devversion @gregmagolan
The first commit performs stamping for experimental packages which get a different version format (e.g.,
0.1302.0-next.1vs13.2.0-next.1). Basically any package with"experimental": truegets the alternative placeholder. If it becomes non-experimental then the version placeholder should also change. The two should be manually kept in sync.The second commit performs substitutions for github snapshot repos in a snapshot build similar to the non-bazel snapshot build, so it stamps versions like
github:angular/angular-devkit-architect-builds:174fe1056a9ca4987c9176f5f2d18faf0e71c92b.