Skip to content

fix(@angular-devkit/build-angular): correct escaping of target warning text in esbuild builder#24154

Merged
dgp1130 merged 1 commit intoangular:mainfrom
clydin:esbuild/correct-warning-text
Oct 28, 2022
Merged

fix(@angular-devkit/build-angular): correct escaping of target warning text in esbuild builder#24154
dgp1130 merged 1 commit intoangular:mainfrom
clydin:esbuild/correct-warning-text

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Oct 27, 2022

The warning text note for the TypeScript target was incorrectly escaped within a template literal which resulted in a badly formatted error message.

…g text in esbuild builder

The warning text note for the TypeScript target was incorrectly escaped within a template literal
which resulted in a badly formatted error message.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Oct 27, 2022
@clydin clydin requested a review from alan-agius4 October 27, 2022 20:33
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 28, 2022
@dgp1130 dgp1130 merged commit 2a6b585 into angular:main Oct 28, 2022
@clydin clydin deleted the esbuild/correct-warning-text branch October 28, 2022 16:42
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants