Skip to content

fix(@angular-devkit/build-angular): show file replacement in TS missing file error in esbuild builder#24218

Merged
dgp1130 merged 1 commit intoangular:mainfrom
clydin:esbuild/improve-missing-file-error
Nov 14, 2022
Merged

fix(@angular-devkit/build-angular): show file replacement in TS missing file error in esbuild builder#24218
dgp1130 merged 1 commit intoangular:mainfrom
clydin:esbuild/improve-missing-file-error

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Nov 11, 2022

When using the experimental esbuild-based browser application builder with the fileReplacements option,
TypeScript missing compilation file errors will now contain a note that the requested file was a
replacement for another file and show the path of the file.

@clydin clydin added target: rc This PR is targeted for the next release-candidate action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 11, 2022
@clydin clydin requested a review from alan-agius4 November 11, 2022 16:37
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 14, 2022
…ng file error in esbuild builder

When using the experimental esbuild-based browser application builder with the `fileReplacements` option,
TypeScript missing compilation file errors will now contain a note that the requested file was a
replacement for another file and show the path of the file.
@clydin clydin force-pushed the esbuild/improve-missing-file-error branch from e15a1cd to 410614b Compare November 14, 2022 14:25
@dgp1130 dgp1130 merged commit 6cc45f6 into angular:main Nov 14, 2022
@clydin clydin deleted the esbuild/improve-missing-file-error branch November 14, 2022 18:43
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants