Skip to content

refactor(@angular-devkit/build-angular): preprocess Sass resolve cache entries in esbuild Sass plugin#24250

Merged
dgp1130 merged 1 commit intoangular:mainfrom
clydin:esbuild/sass-resolve-caching
Nov 18, 2022
Merged

refactor(@angular-devkit/build-angular): preprocess Sass resolve cache entries in esbuild Sass plugin#24250
dgp1130 merged 1 commit intoangular:mainfrom
clydin:esbuild/sass-resolve-caching

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Nov 16, 2022

When performing Sass import resolution within the experimental esbuild-based browser application builder, the directory cache entries will now be preprocessed during the first directory search operation. This will allow a more streamlined search operation on later resolution attempts for the same directory. The caching is still limited to sharing per render request but this change provides for cache entries that can more easily be serialized and shared between workers in the future.

…e entries in esbuild Sass plugin

When performing Sass import resolution within the experimental esbuild-based browser application builder,
the directory cache entries will now be preprocessed during the first directory search operation. This
will allow a more streamlined search operation on later resolution attempts for the same directory.
The caching is still limited to sharing per render request but this change provides for cache entries
that can more easily be serialized and shared between workers in the future.
@clydin clydin added target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 16, 2022
@clydin clydin requested a review from alan-agius4 November 16, 2022 20:13
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 17, 2022
@dgp1130 dgp1130 merged commit bc8578c into angular:main Nov 18, 2022
@clydin clydin deleted the esbuild/sass-resolve-caching branch November 18, 2022 12:08
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants