Skip to content

Conversation

@cexbrayat
Copy link
Member

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The current functional resolver generates:

const executeResolver: ResolveFn<boolean> = ...

it('should be created', () => {
  expect(resolver).toBeTruthy();
});

with resolver a variable that is never declared

What is the new behavior?

const executeResolver: ResolveFn<boolean> = ...

it('should be created', () => {
  expect(executeResolver).toBeTruthy();
});

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Nov 28, 2022

Thanks for this.

@cexbrayat can you also please send a fix for

?

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 28, 2022
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Nov 28, 2022
@cexbrayat
Copy link
Member Author

@alan-agius4 Haha, yes, I was on it #24333

@alan-agius4
Copy link
Collaborator

@alan-agius4 Haha, yes, I was on it #24333

Thanks for next time, it would be better to do a single PR with different commits instead of opening 3 different PRs.

@angular-robot angular-robot bot merged commit 451975f into angular:main Nov 28, 2022
@cexbrayat cexbrayat deleted the fix/resolver-spec branch November 28, 2022 13:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants