Skip to content

feat(@angular-devkit/build-angular): add Less stylesheet support to experimental esbuild-based builder#24643

Merged
angular-robot[bot] merged 2 commits intoangular:mainfrom
clydin:esbuild/less
Feb 8, 2023
Merged

feat(@angular-devkit/build-angular): add Less stylesheet support to experimental esbuild-based builder#24643
angular-robot[bot] merged 2 commits intoangular:mainfrom
clydin:esbuild/less

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Feb 1, 2023

When using the experimental esbuild-based browser application builder, stylesheets written in the Less stylesheet language can now be used throughout an application. The support allows Less stylesheets to be used in all locations where CSS and/or Sass can be used. This includes global stylesheets and both inline and external component styles. When using inline component styles, the inlineLanguageStyle build option must be set to less.
Currently, import resolution within a Less stylesheet is limited to default Less behavior which does not include full node package resolution. Full resolution behavior will be added in a future change.

@clydin clydin added the target: minor This PR is targeted for the next minor release label Feb 1, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 1, 2023
@clydin clydin force-pushed the esbuild/less branch 2 times, most recently from 54e65a2 to fea03bb Compare February 4, 2023 02:10
@clydin clydin marked this pull request as ready for review February 4, 2023 02:10
@clydin clydin requested a review from alan-agius4 February 6, 2023 14:54
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 6, 2023
…xperimental esbuild-based builder

When using the experimental esbuild-based browser application builder, stylesheets written in the Less
stylesheet language can now be used throughout an application. The support allows Less stylesheets to
be used in all locations where CSS and/or Sass can be used. This includes global stylesheets and both
inline and external component styles. When using inline component styles, the `inlineLanguageStyle`
build option must be set to `less`.
Currently, import resolution within a Less stylesheet is limited to default Less behavior which does not
include full node package resolution. Full resolution behavior will be added in a future change.
…t tests for esbuild

With the additional of JIT mode and initial Less stylesheet support, the unit tests for the
`inlineStyleLanguage` build option can now be enabled for the experimental esbuild-based
browser application builder.
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 8, 2023
@angular-robot angular-robot bot merged commit a658464 into angular:main Feb 8, 2023
@clydin clydin deleted the esbuild/less branch February 8, 2023 19:10
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants