Skip to content

feat(@angular-devkit/build-angular): support standalone app-shell generation#24847

Merged
angular-robot[bot] merged 1 commit intoangular:mainfrom
alan-agius4:standalone-support-app-shell
Mar 14, 2023
Merged

feat(@angular-devkit/build-angular): support standalone app-shell generation#24847
angular-robot[bot] merged 1 commit intoangular:mainfrom
alan-agius4:standalone-support-app-shell

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

This commit adds support for generating an app-shell for a standalone application.

The main.server.ts, will need to export a bootstrapping function that returns a Promise<ApplicationRef>.

Example

export default () => bootstrapApplication(AppComponent, {
  providers: [
    importProvidersFrom(ServerModule),
    provideRouter([{ path: 'shell', component: AppShellComponent }]),
  ],
});

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 13, 2023
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Mar 13, 2023
@alan-agius4 alan-agius4 requested a review from clydin March 13, 2023 13:36
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 13, 2023
Comment thread packages/angular_devkit/build_angular/src/builders/app-shell/render-worker.ts Outdated
…eration

This commit adds support for generating an app-shell for a standalone application.

The `main.server.ts`, will need to export a bootstrapping function that returns a `Promise<ApplicationRef>`.

Example
```ts
export default () => bootstrapApplication(AppComponent, {
  providers: [
    importProvidersFrom(ServerModule),
    provideRouter([{ path: 'shell', component: AppShellComponent }]),
  ],
});
```
@alan-agius4 alan-agius4 force-pushed the standalone-support-app-shell branch from 8be0344 to 59c03f5 Compare March 14, 2023 07:17
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 14, 2023
@angular-robot angular-robot bot merged commit 2908020 into angular:main Mar 14, 2023
@alan-agius4 alan-agius4 deleted the standalone-support-app-shell branch March 14, 2023 13:39
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants