Skip to content

Conversation

@cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Mar 24, 2023

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The CLI usually generates files with a new line at the end. This line was lacking in the new app.config.ts file generated for standalone applications.

It was also using a trailing comma, which is not the usual convention in generated files.

What is the new behavior?

Adds the new line at the end of the file, and removes the trailing comma.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The CLI usually generates files with a new line at the end.
This line was lacking in the new `app.config.ts` file generated for standalone applications.

It was also using a trailing comma, which is not the usual convention in generated files.
@cexbrayat cexbrayat force-pushed the fix/app-config-new-line-end-of-file branch from 5156f13 to 6ba662b Compare March 24, 2023 14:24
@cexbrayat cexbrayat changed the title fix(@schematics/angular): add new line at the end of app.config.ts fix(@schematics/angular): reformat app.config.ts Mar 24, 2023
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Mar 24, 2023
@alan-agius4
Copy link
Collaborator

Thanks @cexbrayat

@angular-robot angular-robot bot merged commit ba4414b into angular:main Mar 24, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants