Skip to content

feat(@angular-devkit/build-angular): support module resolution with less stylesheets in esbuild builder#24946

Merged
angular-robot[bot] merged 1 commit intoangular:mainfrom
clydin:esbuild/less-resolution
Apr 4, 2023
Merged

feat(@angular-devkit/build-angular): support module resolution with less stylesheets in esbuild builder#24946
angular-robot[bot] merged 1 commit intoangular:mainfrom
clydin:esbuild/less-resolution

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Apr 3, 2023

When using the esbuild-based browser application builder with Less stylesheets, import rules will now attempt to perform node package resolution if the import cannot be found as a relative path. Built-in Less resolution is performed first to both avoid unnecessary node module resolution overhead when not needed and also ensure Less relative import semantics continue to be supported.

…ess stylesheets in esbuild builder

When using the esbuild-based browser application builder with Less stylesheets, import rules
will now attempt to perform node package resolution if the import cannot be found as a relative
path. Built-in Less resolution is performed first to both avoid unnecessary node module resolution
overhead when not needed and also ensure Less relative import semantics continue to be supported.
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 3, 2023
@clydin clydin marked this pull request as ready for review April 4, 2023 14:16
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 4, 2023
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 4, 2023
@angular-robot angular-robot bot merged commit ce46eca into angular:main Apr 4, 2023
@clydin clydin deleted the esbuild/less-resolution branch April 4, 2023 14:41
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants