refactor(@angular-devkit/build-angular): directly watch package lock files in esbuild builder #24968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files in esbuild builder When using the esbuild-based browser application builder in watch mode, all `node_modules` directories will now be ignored by the file watcher. Instead all relevant package manifests and lock files for `npm`, `yarn, and `pnpm` will be watched to detect potential changes to the project's dependencies. This avoids creating a potentially large amount of filesystem watchers as the node modules directories can be very large.
clydin
force-pushed
the
esbuild/node-modules-watching
branch
from
1529bdc to
0d9a1ea
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Apr 11, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the esbuild-based browser application builder in watch mode, all
node_modulesdirectories will now be ignored by the file watcher. Instead all relevant package manifests and lock files fornpm,yarn, andpnpm` will be watched to detect potential changes to the project's dependencies. This avoids creating a potentially large amount of filesystem watchers as the node modules directories can be very large.