perf(@angular/cli): register CLI commands lazily #25013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: rc
alan-agius4
force-pushed
the
lazy-register-commands
branch
from
a6d3095 to
b2f4f21
Compare
alan-agius4
force-pushed
the
lazy-register-commands
branch
from
b2f4f21 to
2422e89
Compare
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
lazy-register-commands
branch
from
2422e89 to
b966d50
Compare
Currently there is a lot of overhead coming from requiring external modules when registering commands such as `ng update` and `ng add`. This is because these commands do not lazily require all the modules causes the resolution of unneeded packages to be part of the critical path. With this change we "require” only the command that we we need to execute, which reduce the number of node modules resolutions in the critical path.
alan-agius4
force-pushed
the
lazy-register-commands
branch
from
b966d50 to
85f9e6c
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a lot of overhead coming from requiring external modules when registering commands such as
ng updateandng add. This is because these commands do not lazily require all the modules causes the resolution of unneeded packages to be part of the critical path.With this change we "require” only the command that we we need to execute, which reduce the number of node modules resolutions in the critical path.