ci: update CI .bazelrc to better support CI systems.
#25019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of small changes with comments here. The main one is that removing `--noshow_progress` will make Bazel print progress updates which tells Circle CI that test execution is still ongoing and avoids test failures due to lack of output. The other notable trade-offs being made here are: 1. [`--keep_going`](https://bazel.build/docs/user-manual#keep-going) means `bazel test` will run all tests report all failures, which could be slower and noisier than reporting just the first failure but is more complete. 2. [`--build_tests_only`](https://bazel.build/docs/user-manual#build-tests-only) means only tests and binaries will be built, so any library targets not tested could have build errors hidden. Any such important targets should either be tested or use Skylib's `build_test()`. The UI options mostly came from [this talk](https://www.youtube.com/watch?v=j332WfhNAFg).
angular-robot
bot
added
the
area: build & ci
alan-agius4
added
the
action: review
devversion
approved these changes
Apr 14, 2023
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. I'm not 100% sure I like build tests only, but that's fine :)
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of small changes with comments here. The main one is that removing
--noshow_progresswill make Bazel print progress updates which tells Circle CI that test execution is still ongoing and avoids test failures due to lack of output.The other notable trade-offs being made here are:
--keep_goingmeansbazel testwill run all tests report all failures, which could be slower and noisier than reporting just the first failure but is more complete.--build_tests_onlymeans only tests and binaries will be built, so any library targets not tested could have build errors hidden. Any such important targets should either be tested or use Skylib'sbuild_test().The UI options mostly came from this talk.