refactor(@angular-devkit/build-angular): use helper to bundle all elements of esbuild builder #25029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
the
action: review
clydin
force-pushed
the
esbuild/bundle-all-contexts
branch
from
9565e83 to
5e3c514
Compare
clydin
changed the title
clydin
force-pushed
the
esbuild/bundle-all-contexts
branch
from
5e3c514 to
2654e23
Compare
…ments of esbuild builder The code to execute the individual bundling elements of the esbuild-based browser application builder has been consolidated within a bundler context helper method. This moves the execution and result merging code into a single location and allows for more flexibility to control which elements should be executed per build. The global styles and global scripts bundling is now fully skipped if the options are not present in the build configuration.
clydin
force-pushed
the
esbuild/bundle-all-contexts
branch
from
2654e23 to
1be2260
Compare
alan-agius4
approved these changes
Apr 19, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to execute the individual bundling elements of the esbuild-based browser application builder has been consolidated within a bundler context helper method. This moves the execution and result merging code into a single location and allows for more flexibility in control which elements should be executed per build. The global styles and global scripts bundling is now fully skipped if the options are not present in the build configuration.