Skip to content

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Apr 25, 2023

This fixes an issue were we generated files using inconsistent names example app.server.module.ts and app.config.server.ts.

Note: this was discussed and agree with @AndrewKushnir, @alxhub and @pkozlowski-opensource.

…e.server.ts`

This fixes an issue were we generated files using inconsistent names example `app.server.module.ts` and `app.config.server.ts`.
@alan-agius4 alan-agius4 force-pushed the rename-app-server-module branch from be13eb8 to 5db7650 Compare April 25, 2023 06:32
@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 25, 2023
@alan-agius4 alan-agius4 requested a review from clydin April 25, 2023 06:42
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Apr 25, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 25, 2023
@angular-robot angular-robot bot merged commit 603d24f into angular:main Apr 25, 2023
@alan-agius4 alan-agius4 deleted the rename-app-server-module branch April 25, 2023 15:19
dylhunn pushed a commit to angular/angular that referenced this pull request Apr 26, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058

PR Close #49993
dylhunn pushed a commit to angular/angular that referenced this pull request Apr 26, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058

PR Close #49993
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants