Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented May 1, 2023

When using the esbuild-based browser application builder, non-injected global styles and scripts were unintentionally being output with filenames that contain a hash. This can prevent the filenames from being discoverable and therefore usable at runtime. The output filenames will now no longer contain a hash component which matches the behavior of the Webpack-based builder.

@clydin clydin added the target: patch This PR is targeted for the next patch release label May 2, 2023
…cted global styles/scripts

When using the esbuild-based browser application builder, non-injected global styles and scripts
were unintentionally being output with filenames that contain a hash. This can prevent the filenames
from being discoverable and therefore usable at runtime. The output filenames will now no longer
contain a hash component which matches the behavior of the Webpack-based builder.
@clydin clydin force-pushed the esbuild/no-inject-style-hashing branch from 32c52f8 to b9c5cb3 Compare May 3, 2023 18:03
@clydin clydin marked this pull request as ready for review May 3, 2023 18:04
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 3, 2023
@clydin clydin requested a review from alan-agius4 May 3, 2023 18:44
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 4, 2023
@angular-robot angular-robot bot merged commit 2a2817d into angular:main May 4, 2023
@clydin clydin deleted the esbuild/no-inject-style-hashing branch May 4, 2023 20:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Esbuild miss css file when specifying inject: false and bundleName in angular.json style section

2 participants