fix(@angular-devkit/build-angular): clean incoming index URL before processing in esbuild builder #25170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocessing in esbuild builder When using the esbuild-based browser application builder with the development server, the incoming URL for the index HTML may contain search parameters or other URL elements that can cause the index HTML content to not be found or processed incorrected by the development server. These elements are cleaned prior to comparison and the original URL is not longer passed to Vite to avoid unneeded Vite specific processing of the content.
clydin
added
the
action: review
alan-agius4
approved these changes
May 9, 2023
alan-agius4
approved these changes
May 9, 2023
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the esbuild-based browser application builder with the development server, the incoming URL for the index HTML may contain search parameters or other URL elements that can cause the index HTML content to not be found or processed incorrected by the development server. These elements are cleaned prior to comparison and the original URL is not longer passed to Vite to avoid unneeded Vite specific processing of the content.
Closes #25080