fix(@angular-devkit/schematics): do not generate an UpdateBuffer for created and overridden files #25176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: patch
alan-agius4
force-pushed
the
binary-files
branch
3 times, most recently
from
9a7de91 to
667e7aa
Compare
alan-agius4
changed the title
…created and overridden files `UpdateBuffer` only supports UTF-8 encoded files, which causes schematics to emit corrupted binary like files such as images. This commit also introduce an errors when the `UpdateRecorder` is used for non UTF-8 files. Closes angular#25174
clydin
approved these changes
May 9, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateBufferonly supports UTF-8 encoded files, which causes schematics to emit corrupted binary like files such as images.This commit also introduce an errors when the
UpdateRecorderis used for non UTF-8 files.Closes #25174