fix(@angular-devkit/build-angular): percent encode asset URLs in development server for esbuild #25239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lopment server for esbuild When using the esbuild-based browser application builder with the development server, configured application assets are served directly from disk. The URLs passed to Vite are now percent encoded to properly handle asset paths that may contain unsupported URL characters.
clydin
added
target: patch
alan-agius4
approved these changes
May 19, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the esbuild-based browser application builder with the development server, configured application assets are served directly from disk. The URLs passed to Vite are now percent encoded to properly handle asset paths that may contain unsupported URL characters. This aligns with the static middleware within Vite: https://github.com/vitejs/vite/blob/3609e79dc1416073dc4775bb2fcf6a7398f169b3/packages/vite/src/node/server/middlewares/static.ts#L162
Closes #25238