fix(@angular-devkit/build-angular): ignore .git folder in browser-esb… #25265
Conversation
…uild watcher When running the builder in watch mode, and fetching the git repo that the project is contained in, any changes in the .git folder trigger a rebuild. This is especially annoying when the IDE that you use periodically fetches the repository, and the FETCH_HEAD file triggers the rebuild every time. With this change the .git folder will be ignored in the watcher
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
alan-agius4
added
the
target: patch
| // Ignore all node modules directories to avoid excessive file watchers. | ||
| // Package changes are handled below by watching manifest and lock files. | ||
| '**/node_modules/**', | ||
| '**/.git/**', |
There was a problem hiding this comment.
Maybe we should ignore all dotted directories?
There was a problem hiding this comment.
Can't think of any that would cause the same problem as the .git folder.
There was a problem hiding this comment.
@romeomihalovics, one cases could be the cache directory which by default is named .angular for example.
There was a problem hiding this comment.
I've replaced "git" with "*" then, this way every folder starting with a dot should be ignored
…t in browser-esbuild watcher When running the builder in watch mode, and fetching the git repo that the project is contained in, any changes in the .git folder trigger a rebuild. This is especially annoying when the IDE that you use periodically fetches the repository, and the FETCH_HEAD file triggers the rebuild every time. With this change the folders starting with a dot will be ignored in the watcher to avoid similar issues
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When running the builder in watch mode, and fetching the git repo that the project is contained in, any changes in the .git folder trigger a rebuild. This is especially annoying when the IDE that you use periodically fetches the repository, and the FETCH_HEAD file triggers the rebuild every time.
Issue Number: N/A
What is the new behavior?
With this change the .git folder will be ignored in the watcher
Does this PR introduce a breaking change?