refactor(@angular-devkit/build-angular): use fast-glob for file searching support#25297
Merged
clydin merged 1 commit intoangular:mainfrom May 31, 2023
Merged
refactor(@angular-devkit/build-angular): use fast-glob for file searching support#25297clydin merged 1 commit intoangular:mainfrom
clydin merged 1 commit intoangular:mainfrom
Conversation
…hing support The file searching within the build system (both Webpack and esbuild) now use the `fast-glob` package for globbing which provides a small performance improvement. Since the assets option in particular is within the critical path of the buil pipeline, the performance benefit from the switch will be most prevalent in asset heavy projects. As an example, the Angular Material documentation site saw the asset discovery time reduced by over half with the switch. `fast-glob` is also the package used by Vite which provides additional benefit by ensuring that the Angular CLI behavior matches that of the newly integrated Vite development server.
clydin
added
the
action: review
alan-agius4
added
action: merge
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file searching within the build system (both Webpack and esbuild) now use the
fast-globpackage for globbing which provides a small performance improvement. Since the assets option in particular is within the critical path of the buil pipeline, the performance benefit from the switch will be most prevalent in asset heavy projects. As an example, the Angular Material documentation site saw the asset discovery time reduced by over half with the switch.fast-globis also the package used by Vite which provides additional benefit by ensuring that the Angular CLI behavior matches that of the newly integrated Vite development server.