Skip to content

fix(@angular-devkit/build-angular): use all style language watch files in esbuild builder#25435

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
clydin:esbuild/style-watch-files
Jun 26, 2023
Merged

fix(@angular-devkit/build-angular): use all style language watch files in esbuild builder#25435
alan-agius4 merged 1 commit intoangular:mainfrom
clydin:esbuild/style-watch-files

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Jun 23, 2023

A recent change to better support Tailwind CSS in watch mode unintentionally caused part of the watch files list for stylesheets to be ignored when Tailwind and/or autoprefixer were required to be executed. This resulted in rebuilds occurring but all stylesheet changes were not fully propagated to the development server. This has now been corrected.

…s in esbuild builder

A recent change to better support Tailwind CSS in watch mode unintentionally caused part
of the watch files list for stylesheets to be ignored when Tailwind and/or autoprefixer
were required to be executed. This resulted in rebuilds occurring but all stylesheet changes
were not fully propagated to the development server. This has now been corrected.
@clydin clydin added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 23, 2023
@clydin clydin requested a review from alan-agius4 June 23, 2023 15:22
@clydin clydin marked this pull request as ready for review June 23, 2023 16:45
@clydin clydin linked an issue Jun 23, 2023 that may be closed by this pull request
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 26, 2023
@alan-agius4 alan-agius4 merged commit 4cf83eb into angular:main Jun 26, 2023
@clydin clydin deleted the esbuild/style-watch-files branch June 26, 2023 16:16
@princemaple
Copy link
Copy Markdown

Tested 16.1.2, problem still there. Neither updating css files directly (irrelevant to tailwind) nor adding tailwind css classes that weren't previously used during first compilation to an html element made any difference to the appearance of the page.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev serve using ESBuilder does not apply scss changes

3 participants