fix(@angular-devkit/build-angular): correctly load dev server assets with vite 4.4.0+#25577
Merged
clydin merged 1 commit intoangular:mainfrom Jul 25, 2023
Merged
Conversation
clydin
force-pushed
the
esbuild/dev-server-assets-fix
branch
3 times, most recently
from
e71ad65 to
cc3a8fe
Compare
clydin
added
the
action: review
dgp1130
reviewed
Jul 24, 2023
dgp1130
approved these changes
Jul 24, 2023
…with vite 4.4.0+ The underlying development server (Vite) for the application build system updated its static file serving dependencies which resulted in the `@fs` special file URLs supported by Vite to have a different format. Previously, the paths were encoded using `encodeURIComponent` but are now use `encodeURI`. The development server integration with Vite will now use the matching encoding to allow build defined assets to be correctly served.
clydin
force-pushed
the
esbuild/dev-server-assets-fix
branch
from
cc3a8fe to
3e3b778
Compare
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying development server (Vite) for the application build system updated
its static file serving dependencies which resulted in the
@fsspecial file URLssupported by Vite to have a different format. Previously, the paths were encoded
using
encodeURIComponentbut are now useencodeURI. The development serverintegration with Vite will now use the matching encoding to allow build defined
assets to be correctly served.