Skip to content

test: cleanup E2E test regular expressions#25667

Merged
dgp1130 merged 1 commit intoangular:mainfrom
clydin:e2e/cleanup-regex
Aug 11, 2023
Merged

test: cleanup E2E test regular expressions#25667
dgp1130 merged 1 commit intoangular:mainfrom
clydin:e2e/cleanup-regex

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Aug 10, 2023

Several of the older E2E tests that use regular expression based checks have been cleaned up by using string include checks where possible. Several regular expressions have also been simplified where possible.

Several of the older E2E tests that use regular expression based checks have been
cleaned up by using string include checks where possible. Several regular expressions
have also been simplified where possible.
@clydin clydin force-pushed the e2e/cleanup-regex branch from decd80e to 2d89258 Compare August 10, 2023 20:39
@clydin clydin marked this pull request as ready for review August 10, 2023 21:15
@clydin clydin requested a review from alan-agius4 August 10, 2023 21:16
@clydin clydin added the target: major This PR is targeted for the next major release label Aug 10, 2023
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 11, 2023
@dgp1130 dgp1130 merged commit 0d789b7 into angular:main Aug 11, 2023
@clydin clydin deleted the e2e/cleanup-regex branch August 11, 2023 18:43
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants