Skip to content

fix(@schematics/angular): use href property binding for links#26270

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
cexbrayat:fix/link
Nov 8, 2023
Merged

fix(@schematics/angular): use href property binding for links#26270
alan-agius4 merged 1 commit intoangular:mainfrom
cexbrayat:fix/link

Conversation

@cexbrayat
Copy link
Copy Markdown
Member

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The default template uses interpolation instead of a property binding to set the the href value.

What is the new behavior?

Use [href]="item.title"

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 8, 2023
@angular angular deleted a comment from ngbot bot Nov 8, 2023
@alan-agius4 alan-agius4 merged commit da7dea6 into angular:main Nov 8, 2023
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants