test(@angular-devkit/build-angular): enable vite service worker unit tests#26543
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Dec 4, 2023
Merged
test(@angular-devkit/build-angular): enable vite service worker unit tests#26543alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
alan-agius4
added
action: review
…tests Enable service worker tests for vite.
alan-agius4
force-pushed
the
test-service-worker
branch
from
2b65dd0 to
e74aef0
Compare
clydin
reviewed
Dec 2, 2023
Comment on lines
+161
to
+162
| // TODO(fix-vite): currently this is broken in vite due to watcher never terminates. | ||
| (isViteRun ? xit : it)('works in watch mode', async () => { |
Member
There was a problem hiding this comment.
This conditional shouldn't be needed anymore.
Collaborator
Author
There was a problem hiding this comment.
This test still fails, it looks like broken behaviour.
clydin
approved these changes
Dec 2, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable service worker tests for vite.