refactor(@angular-devkit/build-angular): remove deployUrl from browser-esbuild builder-status-warnings#26625
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Dec 11, 2023
Conversation
…r-esbuild builder-status-warnings
Contributor
Author
|
I also wondered if we could change this part if (value === undefined || value === false) {
continue;
}
if (Array.isArray(value) && value.length === 0) {
continue;
}
if (typeof value === 'object' && Object.keys(value).length === 0) {
continue;
}to just if (value === undefined) {
continue;
}because as a user I would still be interested if there is an entry in my angular.json which I could remove. So that e.g. |
alan-agius4
approved these changes
Dec 11, 2023
Collaborator
|
The above mentioned check is still required. As when option is not provided by the users, it will have a default provided in the schema. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The logBuilderStatusWarnings function of browser-esbuild builder checks if unsupportedOption is "deployUrl". However, deployUrl is not in the UNSUPPORTED_OPTIONS array.
Issue Number: N/A
What is the new behavior?
The logBuilderStatusWarnings function of browser-esbuild builder does not check if unsupportedOption is "deployUrl".
Does this PR introduce a breaking change?
Other information