Skip to content

refactor(@angular-devkit/build-angular): remove no longer needed realpathSync#26714

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:real-path-sync
Dec 19, 2023
Merged

refactor(@angular-devkit/build-angular): remove no longer needed realpathSync#26714
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:real-path-sync

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

This is no longer needed since the path provided is already passed through realpathSync.

const workspaceRoot = preserveSymlinks
? context.workspaceRoot
: // NOTE: promises.realpath should not be used here since it uses realpath.native which
// can cause case conversion and other undesirable behavior on Windows systems.
// ref: https://github.com/nodejs/node/issues/7726
realpathSync(context.workspaceRoot);

@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Dec 19, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Dec 19, 2023
@alan-agius4 alan-agius4 merged commit ce9bf81 into angular:main Dec 19, 2023
@alan-agius4 alan-agius4 deleted the real-path-sync branch December 19, 2023 18:25
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants