Skip to content

fix(@angular-devkit/build-angular): fix normalization of the application builder extensions#26805

Merged
dgp1130 merged 1 commit intoangular:mainfrom
leosvelperez:esbuild/fix-application-extensions
Jan 9, 2024
Merged

fix(@angular-devkit/build-angular): fix normalization of the application builder extensions#26805
dgp1130 merged 1 commit intoangular:mainfrom
leosvelperez:esbuild/fix-application-extensions

Conversation

@leosvelperez
Copy link
Copy Markdown
Contributor

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The buildApplication function normalizes the provided extensions incorrectly. When an object of theApplicationBuilderExtensions type is provided with the esbuild plugin and/or the index HTML transformer function, the value is lost and the buildApplicationInternal function is invoked with undefined.

Issue Number: N/A

What is the new behavior?

The buildApplication function normalizes the provided extensions correctly. If an object of ApplicationBuilderExtensions type is provided, it is used as is.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@clydin clydin added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker labels Jan 5, 2024
@dgp1130 dgp1130 merged commit 8d56365 into angular:main Jan 9, 2024
@leosvelperez leosvelperez deleted the esbuild/fix-application-extensions branch January 9, 2024 08:44
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants