Skip to content

refactor(@angular-devkit/build-angular): add experimental builder selector extension for dev-server#26814

Merged
dgp1130 merged 1 commit intoangular:mainfrom
clydin:dev-server/builder-selector-extension
Jan 9, 2024
Merged

refactor(@angular-devkit/build-angular): add experimental builder selector extension for dev-server#26814
dgp1130 merged 1 commit intoangular:mainfrom
clydin:dev-server/builder-selector-extension

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Jan 8, 2024

When using the experimental programmatic API for the development server, the choice of builder used to execute the actual underlying build can now be chosen via a selector function extension option. The returned string value must be one of the first-party esbuild-based builders for the Vite-based development server to be used. All other returned values will cause the Webpack-based development server to be used. The Vite-based development server currently requires one of those builders to be used (either @angular-devkit/build-angular:application or @angular-devkit/build-angular:browser-esbuild).

@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Jan 8, 2024
…ector extension for dev-server

When using the experimental programmatic API for the development server, the choice of builder used
to execute the actual underlying build can now be chosen via a selector function extension option.
The returned string value must be one of the first-party esbuild-based builders for the Vite-based
development server to be used. All other returned values will cause the Webpack-based development
server to be used. The Vite-based development server currently requires one of those builders to
be used (either `@angular-devkit/build-angular:application` or `@angular-devkit/build-angular:browser-esbuild`).
@clydin clydin force-pushed the dev-server/builder-selector-extension branch from b51f515 to 316ae01 Compare January 8, 2024 21:29
@clydin clydin marked this pull request as ready for review January 8, 2024 21:33
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 8, 2024
@clydin clydin requested a review from alan-agius4 January 8, 2024 21:33
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 9, 2024
@dgp1130 dgp1130 merged commit 18a11f5 into angular:main Jan 9, 2024
@clydin clydin deleted the dev-server/builder-selector-extension branch January 9, 2024 17:42
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants