Skip to content

refactor(@angular-devkit/build-angular): update Vite client code loading for v5#26936

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
clydin:dev-server/update-vite-client-load
Jan 24, 2024
Merged

refactor(@angular-devkit/build-angular): update Vite client code loading for v5#26936
alan-agius4 merged 1 commit intoangular:mainfrom
clydin:dev-server/update-vite-client-load

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Jan 24, 2024

Vite v5 updated the client code's error dialog text. This requires that the text replacement code also be updated to remove unactionable information from the error dialog.

…ing for v5

Vite v5 updated the client code's error dialog text. This requires that the
text replacement code also be updated to remove unactionable information from
the error dialog.
@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Jan 24, 2024
@clydin clydin requested a review from alan-agius4 January 24, 2024 00:23
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 24, 2024
@alan-agius4 alan-agius4 merged commit 789a5c4 into angular:main Jan 24, 2024
@clydin clydin deleted the dev-server/update-vite-client-load branch January 24, 2024 12:07
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants