Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Feb 21, 2024

Avoid using fs.Dirent.path in the packages/webpack/test-app E2E test to ensure the test executes properly on Node.js v18.13. The property was not added until v18.17.

@clydin clydin added the target: minor This PR is targeted for the next minor release label Feb 21, 2024
@clydin clydin requested a review from dgp1130 February 21, 2024 18:30
…esting

Avoid using `fs.Dirent.path` in the `packages/webpack/test-app` E2E test
to ensure the test executes properly on Node.js v18.13. The property was
not added until v18.17.
@clydin clydin force-pushed the test/generalize-webpack-direct-test branch from b673bf1 to f15a7f8 Compare February 21, 2024 18:31
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Feb 21, 2024
@dgp1130 dgp1130 merged commit 2609237 into angular:main Feb 21, 2024
@clydin clydin deleted the test/generalize-webpack-direct-test branch February 21, 2024 19:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants