Skip to content

feat(@angular-devkit/build-angular): inject event-dispatcher in SSR HTML page#27480

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:js-action-script
Apr 17, 2024
Merged

feat(@angular-devkit/build-angular): inject event-dispatcher in SSR HTML page#27480
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:js-action-script

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 commented Apr 16, 2024

This commit add support in the Angular CLI to inject the event-dispatcher script when using the application builder.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 16, 2024
@alan-agius4
Copy link
Copy Markdown
Collaborator Author

Blocked on angular/angular#55361 and a FW release.

@alan-agius4 alan-agius4 added state: blocked target: major This PR is targeted for the next major release labels Apr 16, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review April 16, 2024 14:17
@alan-agius4 alan-agius4 requested a review from clydin April 16, 2024 14:19
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 16, 2024
@alan-agius4 alan-agius4 changed the title feat(@angular-devkit/build-angular): inject JSA in SSR HTML page feat(@angular-devkit/build-angular): inject event-dispatcher in SSR HTML page Apr 17, 2024
@alan-agius4 alan-agius4 force-pushed the js-action-script branch 4 times, most recently from b506bc2 to 1196566 Compare April 17, 2024 08:45
@angular-robot angular-robot bot removed the detected: feature PR contains a feature commit label Apr 17, 2024
@alan-agius4 alan-agius4 reopened this Apr 17, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 17, 2024
…L page

This commit add support in the Angular CLI to inject the event-dispatcher script when using the application builder.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 17, 2024
@alan-agius4 alan-agius4 merged commit d51cb59 into angular:main Apr 17, 2024
@alan-agius4 alan-agius4 deleted the js-action-script branch April 17, 2024 17:29
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants