build: additional fixes for tsetse rule compliance#27921
Merged
clydin merged 1 commit intoangular:mainfrom Jun 25, 2024
Merged
Conversation
angular-robot
bot
added
the
area: build & ci
clydin
force-pushed
the
build/tsetse-rules-2
branch
3 times, most recently
from
7ac8985 to
cf6e97e
Compare
Due to bazel rules_nodejs caching, several additional `JSON.parse` usages were not caught in the first set of fixes. These have now been addressed. Also, the `must-use-promises` rule has been patched to match the behavior of the `@typescript-eslint/no-floating-promises` for consistency. The bazel option `suppressTsconfigOverrideWarnings` was also removed from the `tsconfig` as it is a no-op and was previously used for now removed feature. Test files are currently excluded from the `JSON.parse` rule to avoid large changes to test code.
clydin
force-pushed
the
build/tsetse-rules-2
branch
from
cf6e97e to
8a5078e
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Jun 25, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to bazel rules_nodejs caching, several additional
JSON.parseusages were not caught in the first set of fixes. These have now been addressed. Also, themust-use-promisesrule has been patched to match the behavior of the@typescript-eslint/no-floating-promisesfor consistency.