refactor(@angular/build): remove direct usage of undici dependency for SSR#28010
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Jul 8, 2024
Merged
Conversation
…r SSR The Node.js types (`@types/node`) now contains the information for the `Response` class and the global `fetch` function. The `Response` object is also globally accessible in all versions of Node.js supported by the Angular CLI. This removes the need to depend directly on the `undici` package. The `undici` package is still used for unit-testing and remains as a development dependency.
clydin
force-pushed
the
application/remove-undici-dep
branch
from
90c9e2c to
56b77e5
Compare
clydin
added
action: review
alan-agius4
approved these changes
Jul 8, 2024
alan-agius4
approved these changes
Jul 8, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node.js types (
@types/node) now contains the information for theResponseclass and the globalfetchfunction. TheResponseobject is also globally accessible in all versions of Node.js supported by the Angular CLI. This removes the need to depend directly on theundicipackage. Theundicipackage is still used for unit-testing and remains as a development dependency.