Skip to content

Enable several previously disabled lint rules #28026

Merged
alan-agius4 merged 4 commits intoangular:mainfrom
clydin:test/lint-rules-2
Jul 11, 2024
Merged

Enable several previously disabled lint rules #28026
alan-agius4 merged 4 commits intoangular:mainfrom
clydin:test/lint-rules-2

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Jul 10, 2024

Each rule is enabled in a separate commit with relevant fixes when needed.

clydin added 3 commits July 10, 2024 14:04
The `no-fallthrough` rule is now enabled and all failures
have been addressed within the code.
The `@typescript-eslint/prefer-regexp-exec` rule is now enabled.
No code changes were required.
The `no-underscore-dangle` rule is now enabled.
No code changes were required.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Jul 10, 2024
The `no-case-declarations` rule is now enabled and all failures
in have been addressed within the published code. Unit tests
have been excluded.
@clydin clydin requested a review from alan-agius4 July 10, 2024 23:20
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 10, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 11, 2024
@alan-agius4 alan-agius4 merged commit 5895e9f into angular:main Jul 11, 2024
@clydin clydin deleted the test/lint-rules-2 branch July 11, 2024 11:16
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants