refactor(@angular/build): use listr2 for spinner and color support#28029
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Jul 11, 2024
Merged
refactor(@angular/build): use listr2 for spinner and color support#28029alan-agius4 merged 1 commit intoangular:mainfrom
listr2 for spinner and color support#28029alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
clydin
changed the title
listr2` for spinner and color supportlistr2 for spinner and color support
clydin
force-pushed
the
application/spinner-color
branch
from
7848b9e to
fb31923
Compare
clydin
added
the
action: review
The `ansi-color` and `ora` dependencies have been replaced with `listr2`. This package provides both color and spinner capabilities and further reduces the dependency count. This also aligns the dependencies with the `@angular/cli` package with already uses `listr2`. The spinner also now will not overwrite console output that happens to be written while the spinner is active. Instead, the output will be written after the spinner task is complete.
clydin
force-pushed
the
application/spinner-color
branch
from
fb31923 to
1c1d65c
Compare
alan-agius4
approved these changes
Jul 11, 2024
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, do you also plan to make this change in build-angular?
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ansi-colorandoradependencies have been replaced withlistr2. This package provides both color and spinner capabilities and further reduces the dependency count. This also aligns the dependencies with the@angular/clipackage with already useslistr2. The spinner also now will not overwrite console output that happens to be written while the spinner is active. Instead, the output will be written after the spinner task is complete.