Update more packages to npm_package#29318
Merged
devversion merged 3 commits intoangular:mainfrom Jan 13, 2025
Merged
Conversation
angular-robot
bot
added
the
area: build & ci
devversion
added
action: review
alan-agius4
reviewed
Jan 10, 2025
alan-agius4
approved these changes
Jan 10, 2025
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, one minor NIT
devversion
force-pushed
the
npm_package_2
branch
2 times, most recently
from
5634087 to
ef33340
Compare
clydin
approved these changes
Jan 10, 2025
clydin
removed
the
action: review
alan-agius4
force-pushed
the
npm_package_2
branch
2 times, most recently
from
9bc67e3 to
88e2933
Compare
This allows us to use the package in the RJS pnpm workspace.
This allows this package to be used in the pnpm workspace, and is a step further with the `rules_js` migration.
devversion
force-pushed
the
npm_package_2
branch
2 times, most recently
from
df82ca5 to
8a0f8a4
Compare
Similart to `pkg_npm` from `rules_nodejs`, we should have a way to make use of the stamp constants/placeholders throughout individual package files. This is not possible at all with `rules_js`'s `npm_package` rule, nor does it support stamp substitutions out of the box at all. We have our own `expand_template` machinery to substitute `package.json` files of npm archives, but we need to expand this to support arbitrary files inside a package. This will be opt-in for explicitly listed files; which is a good compromise for simplicity of supporting this. This commit adds the necessary functionality and demonstrates the feature by fixing `@angular/build`.
devversion
force-pushed
the
npm_package_2
branch
from
8a0f8a4 to
9204517
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits