test: improve vitest e2e test stability and performance #31843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use Chrome binary from `rules_browsers` for Playwright in Vitest browser tests for hermetic testing. - Batch `ng generate` commands in e2e tests to improve performance. - Remove now redundant chromium install commands from e2e tests.
alan-agius4
commented
Nov 17, 2025
| ); | ||
| } | ||
|
|
||
| async function generateArtifactsInBatches(artifactCount: number): Promise<void> { |
Collaborator
Author
There was a problem hiding this comment.
When running this locally I noticed that it was rather slow, so I went ahead and added batching.
alan-agius4
added
the
target: rc
alan-agius4
added
the
action: review
clydin
approved these changes
Nov 17, 2025
alan-agius4
added
action: merge
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_browsersfor Playwright in Vitest browser tests for hermetic testing and avoids re-downloads of chrome.ng generatecommands in e2e tests to improve performance.