test(@angular-devkit/build-webpack): remove unused createConsoleLogger usage#33171
Merged
alan-agius4 merged 2 commits intoMay 13, 2026
Merged
Conversation
…r usage Removes the last usage of `createConsoleLogger` in the repository from the webpack builder tests. This makes the test consistent with others in the file and allows for potential removal of the function. Also removes an unused `BuildResult` import in the same file.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the Webpack builder test suite by removing unused imports, specifically createConsoleLogger and BuildResult, and streamlining the architect.scheduleTarget call within the 'works' test case. I have no feedback to provide as no review comments were submitted.
`createConsoleLogger` is deprecated. Use a custom logger implementation instead. This does not apply to application code.
clydin
force-pushed
the
test/remove-createConsoleLogger-usage
branch
from
146238e to
77b383b
Compare
clydin
added
target: rc
alan-agius4
approved these changes
May 12, 2026
alan-agius4
added
target: rc
alan-agius4
approved these changes
May 12, 2026
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last usage of
createConsoleLoggerin the repository from the webpack builder tests. This makes the test consistent with others in the file and allows for potential removal of the function.