feat(build): add --poll option to build/serve/test commands
#4268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
approved these changes
Jan 28, 2017
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
LGTM aside from the extra doc change.
|
|
||
| `--output-hashing` define the output filename cache-busting hashing mode | ||
|
|
||
| `--poll` enable and define the file watching poll time period (milliseconds) |
Contributor
There was a problem hiding this comment.
Can you add this flag to the serve doc as well?
filipesilva
suggested changes
Jan 28, 2017
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
A test in https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/build/rebuild.ts#L20 should also be added. Rebuilds should be triggered with --poll without touching files.
clydin
changed the title
--poll option to build/serve commands--poll option to build/serve/test commands
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates
build --watchto use the poll setting if present.Closes #4255