Skip to content

Conversation

@alan-agius4
Copy link
Collaborator

With this change we update the validation of the libraries and application projects names to fully allow characters that make a valid NPM package name. http://json.schemastore.org/package has been used as reference.

We also remove validators that are no longer needed.

Closes #11051

@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Nov 15, 2021
@google-cla google-cla bot added the cla: yes label Nov 15, 2021
@alan-agius4 alan-agius4 changed the title feat(@schematics/angular): loosen project names validation feat(@schematics/angular): loosen project name validation Nov 15, 2021
@alan-agius4 alan-agius4 requested a review from clydin November 15, 2021 10:52
With this change we update the validation of the libraries and application projects names to fully allow characters that make a valid NPM package name. http://json.schemastore.org/package has been used as reference.

We also remove validators that are no longer needed.

Closes #11051
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2021
@filipesilva filipesilva merged commit 21809e1 into angular:master Nov 16, 2021
@alan-agius4 alan-agius4 deleted the project-name-loosen branch November 16, 2021 12:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng new <project-name> -- Using "." or "_" in"project-name" produces errors.

3 participants