Skip to content

Conversation

devversion
Copy link
Member

  • Removes interop_deps from the ts_project interop macro.
  • Keeps _rjs suffix for now as we still need the interop targets for e.g. jasmine_node_test and the rules_nodejs linker.

In follow-ups we can remove the suffix, and interop layer.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 8, 2025
* Removes `interop_deps` from the `ts_project` interop macro.
* Keeps `_rjs` suffix for now as we still need the interop targets for
  e.g. `jasmine_node_test` and the `rules_nodejs` linker.

In follow-ups we can remove the suffix, and interop layer.
@devversion devversion added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 8, 2025
@devversion devversion marked this pull request as ready for review January 8, 2025 17:12
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 8, 2025
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jan 8, 2025
@clydin clydin added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Jan 8, 2025
@alan-agius4 alan-agius4 merged commit a8335cf into angular:main Jan 9, 2025
35 checks passed
@alan-agius4
Copy link
Collaborator

The changes were merged into the following branches: main, 19.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants