build: migrate @angular-devkit/architect to npm_package
#29312
Conversation
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
migrate_npm_package
branch
4 times, most recently
from
711bbcb to
29b6e8f
Compare
Migrates the `@angular-devkit/architect` package to the `rules_js` npm package rule, consuming the direct `rules_ts` output JS files. Notably, substitution is FAR different than what it used to be with `rules_nodejs`, so we needed some extra work to leverage `make_template` for substitutions in `package.json` files. **Keep in mind** that for now, this does not apply to any other files; so we only substitute in the `package.json`, but not in e.g. `.js` files as before. We will follow-up on this. The other jq merging/filtering for snapshot or tar references in `package.json` files is kept as is, and is temporarily duplicated. This is acceptable as the migration should be pretty smooth and quick.
devversion
force-pushed
the
migrate_npm_package
branch
from
29b6e8f to
2c63962
Compare
Include JSON files
devversion
force-pushed
the
migrate_npm_package
branch
from
67ea36f to
fee3b95
Compare
devversion
added
action: merge
tools/defaults2.bzl
Outdated
| out = "substituted_with_snapshot_repos/package.json", | ||
| ) | ||
|
|
||
| expand_template( |
There was a problem hiding this comment.
This is newly added. The rest above is the same like before.
tools/defaults2.bzl
Outdated
| stamp_substitutions = get_npm_package_substitutions_for_rjs(), | ||
| ) | ||
|
|
||
| _npm_package( |
There was a problem hiding this comment.
This is mostly the same as before too. Just that copy_files_to_directory is now _npm_package.
devversion
added
target: minor
| @@ -0,0 +1,8 @@ | |||
| load("//tools:interop.bzl", _ts_project = "ts_project") | |||
There was a problem hiding this comment.
NIT: maybe a more meaningful filename? (defaults-interop) etc..
There was a problem hiding this comment.
Yeah, we'll rename that in a follow-up. Probably bazel/ts_project_interop.bzl
|
The changes were merged into the following branches: main, 19.1.x |
|
Proof that this change didn't affect npm output: angular/angular-devkit-architect-builds@83afe99 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Migrates the
@angular-devkit/architectpackage to therules_jsnpm package rule, consuming the directrules_tsoutput JS files.Notably, substitution is FAR different than what it used to be with
rules_nodejs, so we needed some extra work to leveragemake_templatefor substitutions inpackage.jsonfiles. Keep in mind that for now, this does not apply to any other files; so we only substitute in thepackage.json, but not in e.g..jsfiles as before. We will follow-up on this.The other jq merging/filtering for snapshot or tar references in
package.jsonfiles is kept as is, and is temporarily duplicated. This is acceptable as the migration should be pretty smooth and quick.