Skip to content

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Jan 15, 2025

Need to wait for FW release for CI to pass.

@dgp1130 dgp1130 added state: blocked target: rc This PR is targeted for the next release-candidate labels Jan 15, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 15, 2025
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run yarn bazel run @npm2//:sync and commit the changes. Once the FW releases.

@dgp1130
Copy link
Collaborator Author

dgp1130 commented Jan 15, 2025

You need to run yarn bazel run @npm2//:sync and commit the changes. Once the FW releases.

Thanks for that callout, will do.

@alan-agius4 alan-agius4 dismissed their stale review January 15, 2025 18:54

To unblock.

@dgp1130
Copy link
Collaborator Author

dgp1130 commented Jan 15, 2025

I dropped the devDependencies updates as they included Angular Components packages which haven't released yet.

I also ran @npm2//:sync but it seems to be a no-op since the main package.json didn't change.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Jan 15, 2025
@dgp1130 dgp1130 merged commit 6ea8b5c into angular:19.1.x Jan 15, 2025
31 checks passed
@dgp1130 dgp1130 deleted the minor-bump branch January 15, 2025 22:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants