[19.1.x] build: migrate @angular-devkit/architect jasmine test to native rules_js
#29356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary as `rules_js` requires this "common name" when dealing with Yarn workspaces, linking first party dependencies automatically. In the future, we may be able to send a PR to `rules_js` to support a custom name somehow.
This is necessary as with the new compilation, leveraging pnpm-linked first party dependencies, there are cases **during migration** where multiple locations of the same package exist. e.g. - `@angular_devkit/architect/node_modules/@angular-devkit/core` (pnpm package output) - `@angular_devkit/core` (plain js sources) This is fine, and there is no risk of wrong types, and this should only occur during migration anyway, but it causes a few type issues as TypeScript is unable to emit proper types for inference. This is okay, as we'd likely even want to make use of `isolatedDeclarations` at some point, but we just add explicit types right now. (also making `Builder` type more type safe, checking assignability properly).
…les_js` Instead of using `rules_nodejs` interop and the linker at runtime, the test target is migrated to the new `jasmine_test` rule, leveraging the pnpm workspace for first-party dependencies. Note that in the future we may be able to rename the local node modules to something more clear. e.g. `:local_modules/@angular-devkit/core`, but for now this is not possible :( This commit shows how similar packages can be migrated in the future.
devversion
added
the
target: rc
angular-robot
bot
added
the
area: build & ci
devversion
added
action: review
devversion
changed the title
rules_js@angular-devkit/architect jasmine test to native rules_js
clydin
approved these changes
Jan 15, 2025
devversion
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"rc" port of #29349