Migrate more jasmine tests #29371
Merged
Migrate more jasmine tests #29371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
more-jasmine-tests
branch
4 times, most recently
from
fac0ee2 to
38a529c
Compare
We'll be using `workspace:*` protocol links to link first-party packages together in the pnpm workspace. For this reason, we need to make sure they are properly replaced in `package.json` files, before packaging.
Integrates `@angular/cli` into the pnpm workspace and wires up the native `rules_js` rules. One nice benefits that highlight here: - `resolve` runtime dependency is only installed in the CLI folder, and we can pull it from there. --> Locally managed deps! :yay:
Migrates `@angular-devkit/core` jasmine rules to the native `rules_js` variant.
Migrates `@angular-devkit/schematics` jasmine rules to the native `rules_js` variant. As part of this commit, we are performing a few adjustments that we've discussed as preparation for this migration: - cross package imports are always using the module name - inside package imports are always using relative imports, matching existing tests, fixing a few outliers.
Migrates `@angular-devkit/architect-cli` jasmine rules to the native `rules_js` variant.
devversion
force-pushed
the
more-jasmine-tests
branch
from
38a529c to
bb74a26
Compare
devversion
added
action: review
alan-agius4
approved these changes
Jan 17, 2025
alan-agius4
added
target: minor
|
@devversion I changed the target to |
`rules_js` doesn't integrate source maps by default, so we are enabling it by default via `defaults2.bzl`.
devversion
force-pushed
the
more-jasmine-tests
branch
from
9ba7447 to
7997d0e
Compare
alan-agius4
approved these changes
Jan 17, 2025
devversion
added
action: merge
The strategy tests are extremely time-sensitive with regards to the RxJS job logic executing, and the tests currently rely on `setImmediate` to flush/trigger job execution. This seems to be rather unstable via Remote execution, and sensitive to changes with the execution (e.g. injecting source map support or not), so we are stabilizing the tests further by having better time delays for job execution, and by using `setTimeout` for flushing. This seems very sufficient.
devversion
force-pushed
the
more-jasmine-tests
branch
from
7997d0e to
a6b5f03
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits