test: remove E2E test for ngrx Effect decorator usage #29821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `misc/third-party-decorators` E2E test has been deleted as its purpose was to test the usage of the now removed `Effect` decorator from `ngrx`.
clydin
force-pushed
the
test/update-e2e-ngrx-deps
branch
from
34282ec to
dffc949
Compare
clydin
changed the title
clydin
added
the
action: review
alan-agius4
approved these changes
Mar 12, 2025
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
misc/third-party-decoratorsE2E test has been deleted as its purpose was to test the usage of the now removedEffectdecorator fromngrx. Version 14 which contains theEffectdecorator does not support use with the upcoming Angular v20 and will result in a compilation error due to the removal of theInjectFlagsexport.https://github.com/angular/angular-cli/actions/runs/13814669150/job/38644847372?pr=29798#step:6:1235