refactor(@schematics/angular): use generateFromFiles helper in more cases

packages/schematics/angular/class/index.ts

@@ -11,7 +11,5 @@ import { generateFromFiles } from '../utility/generate-from-files';
 import { Schema as ClassOptions } from './schema';
 
 export default function (options: ClassOptions): Rule {
-  options.type = options.type ? `.${options.type}` : '';
-
   return generateFromFiles(options);
 }

packages/schematics/angular/directive/index.ts

@@ -40,9 +40,6 @@ export default function (options: DirectiveOptions): Rule {
 
     options.module = findModuleFromOptions(host, options);
 
-    // Schematic templates require a defined type value
-    options.type ??= '';
-
     const parsedPath = parseName(options.path, options.name);
     options.name = parsedPath.name;
     options.path = parsedPath.path;

packages/schematics/angular/interface/index.ts

@@ -11,7 +11,5 @@ import { generateFromFiles } from '../utility/generate-from-files';
 import { Schema as InterfaceOptions } from './schema';
 
 export default function (options: InterfaceOptions): Rule {
-  options.type = options.type ? `.${options.type}` : '';
-
   return generateFromFiles(options);
 }

packages/schematics/angular/service/index.ts

@@ -11,14 +11,5 @@ import { generateFromFiles } from '../utility/generate-from-files';
 import { Schema as ServiceOptions } from './schema';
 
 export default function (options: ServiceOptions): Rule {
-  // This schematic uses an older method to implement the flat option
-  const flat = options.flat;
-  options.flat = true;
-
-  // Schematic templates require a defined type value
-  options.type ??= '';
-
-  return generateFromFiles(options, {
-    'if-flat': (s: string) => (flat ? '' : s),
-  });
+  return generateFromFiles(options);
 }

packages/schematics/angular/utility/add-declaration-to-ng-module.ts

@@ -37,11 +37,11 @@ export function addDeclarationToNgModule(options: DeclarationToNgModuleOptions):
       `/${options.path}/` +
       (options.flat ? '' : strings.dasherize(options.name) + '/') +
       strings.dasherize(options.name) +
-      (options.type ? '.' : '') +
-      strings.dasherize(options.type);
+      (options.type ? '.' + strings.dasherize(options.type) : '');
 
     const importPath = buildRelativePath(modulePath, filePath);
-    const classifiedName = strings.classify(options.name) + strings.classify(options.type);
+    const classifiedName =
+      strings.classify(options.name) + (options.type ? strings.classify(options.type) : '');
     const changes = addDeclarationToModule(source, modulePath, classifiedName, importPath);
 
     if (options.export) {

packages/schematics/angular/utility/generate-from-files.ts

@@ -45,6 +45,9 @@ export function generateFromFiles(
     options.prefix ??= '';
     options.flat ??= true;
 
+    // Schematic templates require a defined type value
+    options.type ??= '';
+
     const parsedPath = parseName(options.path, options.name);
     options.name = parsedPath.name;
     options.path = parsedPath.path;