Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented May 5, 2025

The internal bundler (esbuild) may use virtual files to represent added content to the output files. This includes names such as <define:???> and <runtime> to reference object define values and runtime code, respectively. It may also use paths that end with (disabled):<node_builtin_name> where <node_builtin_name> is one of Node.js' builtin modules. All these cases are now handled by the file watching system and will not be attempted to be watched. Previously these virtual files would be considered removed by the file watching system as they do not actually exist on the file system.

Closes #30197

The internal bundler (`esbuild`) may use virtual files to represent added
content to the output files. This includes names such as `<define:???>` and
`<runtime>` to reference object define values and runtime code, respectively.
It may also use paths that end with `(disabled):<node_builtin_name>` where
`<node_builtin_name>` is one of Node.js' builtin modules. All these cases
are now handled by the file watching system and will not be attempted to
be watched. Previously these virtual files would be considered removed by
the file watching system as they do not actually exist on the file system.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label May 5, 2025
@clydin clydin marked this pull request as ready for review May 5, 2025 18:32
@clydin clydin requested a review from alan-agius4 May 5, 2025 18:32
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 6, 2025
@clydin clydin added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels May 6, 2025
@clydin clydin merged commit 27f7007 into angular:main May 6, 2025
35 checks passed
@clydin
Copy link
Member Author

clydin commented May 6, 2025

The changes were merged into the following branches: main, 19.2.x, 20.0.x

@clydin clydin deleted the application/avoid-watch-internal branch May 6, 2025 10:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit tests using esbuild + Vite will rebuild during initial test run when using a large dependency

2 participants